-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Entity Analytics] [8.18 Only] Add deprecation warning for the legacy risk score modules #202775
Conversation
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy looks good, just left some minor suggestions, thanks!
x-pack/plugins/security_solution/server/deprecations/register_risk_score_modules_deprecation.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/deprecations/register_risk_score_modules_deprecation.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/deprecations/register_risk_score_modules_deprecation.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/deprecations/register_risk_score_modules_deprecation.ts
Outdated
Show resolved
Hide resolved
…risk_score_modules_deprecation.ts Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
…risk_score_modules_deprecation.ts Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
…risk_score_modules_deprecation.ts Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
/ci |
/ci |
@elasticmachine merge upstream |
/ci |
…na into deprecate-risk-score-module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor doc fixes, otherwise LGTM
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @hop-dev |
Summary
Note
Example deployment with data loaded (message me for credentials): https://kibana-pr-202775.kb.us-west2.gcp.elastic-cloud.com/app/management/stack/upgrade_assistant/kibana_deprecations
Add a deprecation warning when users have the risk scoring modules/legacy risk engine installed.
We are removing the legacy risk engine in 9.0.0 which means users data will be there in the index but the UI won’t display it, scores will even continue to be calculated if they for some reason don’t upgrade to the new risk engine. But there will be no dedicated views in kibana.
In 8.18 we are adding an upgrade assistant warning if they have the legacy risk engine installed, this is to guide them to upgrade.
I have tried to use the same language as our documentation by calling it the risk score module.
Upgrade Assistant List view:
Clicking the deprecation:
Test Steps
yarn start generate-legacy-risk-score
command.