Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Entity Analytics] [8.18 Only] Add deprecation warning for the legacy risk score modules #202775

Merged
merged 17 commits into from
Dec 17, 2024

Conversation

hop-dev
Copy link
Contributor

@hop-dev hop-dev commented Dec 3, 2024

Summary

Add a deprecation warning when users have the risk scoring modules/legacy risk engine installed.

We are removing the legacy risk engine in 9.0.0 which means users data will be there in the index but the UI won’t display it, scores will even continue to be calculated if they for some reason don’t upgrade to the new risk engine. But there will be no dedicated views in kibana.

In 8.18 we are adding an upgrade assistant warning if they have the legacy risk engine installed, this is to guide them to upgrade.

I have tried to use the same language as our documentation by calling it the risk score module.

Upgrade Assistant List view:
Screenshot 2024-12-12 at 09 40 36

Clicking the deprecation:
Screenshot 2024-12-13 at 10 59 21

Test Steps

  • on a system with the legacy risk module installed
    • I used the security-documents-generator yarn start generate-legacy-risk-score command.
    • You would have to deploy an 8.11 system to install it through the UI
  • navigate the the update assistant in stack management
  • notice the deprecation warning is displayed
  • upgrade your risk engine by navigating to security > management > entity risk score and clicking start upgrade
  • notice the deprecation warning is no longer displayed.

@hop-dev hop-dev self-assigned this Dec 3, 2024
@hop-dev hop-dev added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Entity Analytics Security Entity Analytics Team v8.18.0 labels Dec 3, 2024
@hop-dev hop-dev marked this pull request as ready for review December 3, 2024 20:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@hop-dev hop-dev added ci:project-deploy-security Create a Security Serverless Project release_note:deprecation backport:skip This commit does not require backporting labels Dec 4, 2024
@hop-dev hop-dev changed the title [Entity Analytics] Add deprecation warning for the legacy risk score modules [Entity Analytics] [8.18 Only] Add deprecation warning for the legacy risk score modules Dec 4, 2024
@hop-dev hop-dev added ci:cloud-deploy Create or update a Cloud deployment and removed ci:project-deploy-security Create a Security Serverless Project labels Dec 4, 2024
@hop-dev
Copy link
Contributor Author

hop-dev commented Dec 4, 2024

@elasticmachine merge upstream

@hop-dev
Copy link
Contributor Author

hop-dev commented Dec 9, 2024

@elasticmachine merge upstream

Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy looks good, just left some minor suggestions, thanks!

@hop-dev hop-dev marked this pull request as draft December 11, 2024 12:12
hop-dev and others added 5 commits December 11, 2024 12:13
…risk_score_modules_deprecation.ts

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
…risk_score_modules_deprecation.ts

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
…risk_score_modules_deprecation.ts

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
@hop-dev
Copy link
Contributor Author

hop-dev commented Dec 12, 2024

/ci

@hop-dev hop-dev marked this pull request as ready for review December 12, 2024 13:28
@hop-dev
Copy link
Contributor Author

hop-dev commented Dec 13, 2024

/ci

@hop-dev
Copy link
Contributor Author

hop-dev commented Dec 13, 2024

@elasticmachine merge upstream

@hop-dev
Copy link
Contributor Author

hop-dev commented Dec 13, 2024

/ci

@natasha-moore-elastic natasha-moore-elastic requested a review from a team December 13, 2024 11:56
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor doc fixes, otherwise LGTM

docs/upgrade-notes.asciidoc Outdated Show resolved Hide resolved
docs/upgrade-notes.asciidoc Outdated Show resolved Hide resolved
hop-dev and others added 2 commits December 16, 2024 15:30
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
@hop-dev
Copy link
Contributor Author

hop-dev commented Dec 16, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 16, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 93.4KB 93.4KB +85.0B
lists 145.8KB 145.8KB +85.0B
total +170.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 450.8KB 450.9KB +85.0B

History

cc @hop-dev

@hop-dev hop-dev merged commit 217eb98 into elastic:8.x Dec 17, 2024
8 checks passed
@hop-dev hop-dev deleted the deprecate-risk-score-module branch December 17, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:deprecation Team:Entity Analytics Security Entity Analytics Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants